hokein marked an inline comment as done.
hokein added inline comments.
================
Comment at: test/CMakeLists.txt:36
set(CLANG_TOOLS_TEST_DEPS
# For the clang-apply-replacements test that uses clang-rename.
----------------
sammccall wrote:
> can we add all of clangd to this list with a loop, instead of duplicating?
We could do this, or alternatively we can remove all clangd-related binaries,
and add `check-clangd` target. The only difference is that the output will
change a bit, like below, I think this is not a big deal, WDYT?
```
[0/2] Running the Clangd regression tests
Testing Time: 2.78s
Expected Passes : 343
Unsupported Tests : 1
[1/2] Running the Clang extra tools' regression tests
Testing Time: 4.08s
Expected Passes : 1001
Unsupported Tests : 2
```
================
Comment at: test/CMakeLists.txt:107
+add_lit_testsuite(check-clangd "Running the Clangd regression tests"
+ ${CMAKE_CURRENT_BINARY_DIR}/Unit/clangd;${CMAKE_CURRENT_BINARY_DIR}/clangd
+ DEPENDS ${CLANGD_TEST_DEPS}
----------------
sammccall wrote:
> Is /Unit/ really right?
Yes, indeed. It is used for running unittest (we have lit configuration file in
`test/Unit/` directory).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52710
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
