sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Awesome! Please do remove that duplication if it's easy. ================ Comment at: test/CMakeLists.txt:36 set(CLANG_TOOLS_TEST_DEPS # For the clang-apply-replacements test that uses clang-rename. ---------------- hokein wrote: > sammccall wrote: > > can we add all of clangd to this list with a loop, instead of duplicating? > We could do this, or alternatively we can remove all clangd-related binaries, > and add `check-clangd` target. The only difference is that the output will > change a bit, like below, I think this is not a big deal, WDYT? > > ``` > [0/2] Running the Clangd regression tests > Testing Time: 2.78s > Expected Passes : 343 > Unsupported Tests : 1 > [1/2] Running the Clang extra tools' regression tests > Testing Time: 4.08s > Expected Passes : 1001 > Unsupported Tests : 2 > ``` > Yes, that looks great! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52710 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
