On Mon, 13 Jul 2026 16:55:46 GMT, Andrew Haley <[email protected]> wrote:
>> ...also, I do not see these checks on `x86`. Are they needed there? Are they >> really needed at all? > > Fixed. > > They're only on AArch64 because I wanted to make sure that all of the entries > and exits were covered, and it's not necessary to do that on every target. I > could do so for consistency. Failing on one platform (_it will be the one in CI..._) but not on the platform (_which I probably have for development_) is not convenient. What is the purpose of those checks? It does not look like the `0` state is sticky, given either CRC32 or `+1` in LCG. And with CRC32 you can still hit `0` with 2^-32 probability? So I would rather think whether we should bother with these checks even on AArch64... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3572632747
