On Fri, 10 Jul 2026 09:49:04 GMT, Andrew Haley <[email protected]> wrote:
>> src/hotspot/share/ci/ciEnv.cpp line 1074:
>>
>>> 1072: compiler,
>>> CompLevel(task()->comp_level()),
>>> 1073: nmethod::Flags(has_unsafe_access,
>>> has_wide_vectors, has_monitors, has_scoped_access));
>>> 1074: {
>>
>> I don't see why this move is needed?
>
> It's another leftover.
>
> Something that I have always hated: code is installed and run _before_ it is
> printed. So, if it crashes, too bad.
>
> I should submit this fix as a separate PR.
Yeah, pull it to separate PR. As always, I would not be surprised if
`NoSafepointVerifier` move gives us some grief, and maybe some nmethod
lifecycle oddities show up now that we `post_compiled_method` before the method
is actually installed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3570116344
