On Mon, 13 Jul 2026 11:33:43 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Still bothers me. `state` *is* `r_profile_rng`, right? So test that?
>> 
>> And the second part of my original comment is unresolved: isn't state `0` 
>> normally reachable? Isn't `LGC(69069, 1, 2^32)` full-period in 2^32? So `0` 
>> is trivially reachable, and we should be hitting this assert with 
>> `-XX:-UseCRC32`?
>
> ...also, I do not see these checks on `x86`. Are they needed there? Are they 
> really needed at all?

Fixed. 

They're only on AArch64 because I wanted to make sure that all of the entries 
and exits were covered, and it's not necessary to do that on every target. I 
could do so for consistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3572545386

Reply via email to