On Tue, 26 Nov 2024 00:40:22 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8344093-x86-32-deprecation >> - Merge branch 'master' into JDK-8344093-x86-32-deprecation >> - Merge branch 'master' into JDK-8344093-x86-32-deprecation >> - Initial work > > make/autoconf/platform.m4 line 673: > >> 671: AC_MSG_WARN([The x86 port is deprecated and may be removed in a >> future release.]) >> 672: else >> 673: AC_MSG_ERROR(m4_normalize([The 32-bit x86 port is deprecated and >> may be removed in a future release. > > Shouldn't this wording be the same in both cases? Right, it should. The only difference is whether this message is an error or a warning. Fixed in new commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22062#discussion_r1858149822
