On Tue, 29 Oct 2024 09:34:09 GMT, David Holmes <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix NativeLookup::lookup_entry
>
> src/hotspot/share/prims/nativeLookup.cpp line 350:
>
>> 348: if (entry != nullptr) return entry;
>> 349:
>> 350: // 3) Try JNI short style without os prefix/suffix
>
> Please update comment as there is no os prefix/suffix now
Actually, it was not just the comment that were wrong, it was the actual code
("if the comment and code don't agree, then most likely both are wrong").
The steps 3 and 4 were just 1 and 2 without the os prefix/suffix, which we do
not need anymore. I removed 4 but for some reason I did not realize that I
should remove 3 as well. And I kept an unnecessary `if (entry != nullptr)
return entry;`...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1820979841
