On Tue, 29 Oct 2024 10:37:52 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains seven commits: >> >> - Update VirtualMachineImpl_openProcess since it only needs to care about >> 64-bit >> - Merge branch 'master' into impl-JEP-479 >> - Use #error for unknown CPU >> - Restore PLATFORM_CHECK_DEPRECATION >> - Remove FIXMEs on x86 code that will soon go away anyway >> - Remove FIXME for issue resolved in JDK-8343167 >> - 8339783: Implementation of JEP 479: Remove the Windows 32-bit x86 Port > > src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c line 246: > >> 244: CloseHandle(hProcess); >> 245: JNU_ThrowByName(env, >> "com/sun/tools/attach/AttachNotSupportedException", >> 246: "Unable to attach to 32-bit process running under >> WOW64"); > > The comment just before this will need to be updated as the scenario as the > tool side will always be 64-bit and just need to handle a 32-bit target VM. Good catch. I also simplified the code, now that we know that our process is 64 bit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1820966986
