On Fri, 25 Oct 2024 20:31:40 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> test/jdk/javax/swing/JPopupMenu/6691503/bug6691503.java line 1:
>> 
>>> 1: /*
>> 
>> I think we can delete this test. It verifies that popup menus are displayed 
>> in a windows `isAlwaysOnTop() == true` in stand-alone apps whereas for 
>> applets `isAlwaysOnTop() == false`.
>> 
>> If there's no such distinction, the test tests nothing but the fact that 
>> popup menus are displayed in always-on-top windows.
>> 
>> The updated test does not test anything for 
>> [JDK-6691503](https://bugs.openjdk.org/browse/JDK-6691503) and its changeset 
>> https://github.com/openjdk/jdk/commit/8dff6c648be296799e4a7e0e1964d339acc0d724.
>
> This test was initially deleted but then restored based on the following 
> comment - https://github.com/openjdk/jdk/pull/21498#discussion_r1810297085
> 
> Since this test falls under similar category as 
> test/jdk/javax/swing/JPopupMenu/6691503/bug6691503.java and based on your 
> suggestion, I think we can delete it if it doesn't hold value after SM 
> removal.

Fixed in 
https://github.com/openjdk/jdk/pull/21498/commits/aca9555a0b697bd9829224396a5448c88057009d

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819190841

Reply via email to