On Fri, 25 Oct 2024 23:45:26 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> I'm not sure what would be a useful message. All the `SecurityManager` check 
>> methods throw a `SecurityException` with no message. We had to specify 
>> something here because `AccessControlException` doesn't have a no-args ctor.
>
> I see. Maybe this is enough.

Actually, I changed the message to "checking permissions is not supported" 
which is the same as the exception message of`Permission.checkGuard` and 
`AccessController.checkPermission`.

https://github.com/openjdk/jdk/pull/21498/commits/b6fe405dbbe8ec19a18174bc48dd649feca3d6aa

>> You mean move the first sentence of the deprecated text to here?
>
> Oh, I just meant the class spec should have a body text. This is similar to 
> my previous comment on the `Policy` class.

Fixed in 
https://github.com/openjdk/jdk/pull/21498/commits/09b6cd602c1f2c7998ed824878c5f5f43be69075

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819161320
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819162666

Reply via email to