On Fri, 25 Oct 2024 20:07:57 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 186 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Update copyrights. Remove @compile line form Marshal.java test. >> - Update copyright headers >> - Adjust Executors.privilegedThreadFactory to make clear that thread uses >> current CCL >> - Merge branch 'master' into jep486 >> - ResourceBundle/modules/security/* no longer needed. TestPermission tested >> against getModule(String, Module) w/ SM. >> - remove privileged calls in logging/File* tests >> - delete PermissionTest.java as it simply constructs provider impls >> - remove non enforced/redundant comment in >> TestLogConfigurationDeadLockWithConf.java >> - clientlibs: Updated javax/swing/UIDefaults/6622002/bug6622002.java >> Removed createPrivateValue(), no longer used. >> - ... and 176 more: https://git.openjdk.org/jdk/compare/df3473e2...2f90c839 > > test/jdk/java/util/ResourceBundle/modules/security/src/test/jdk/test/Main.java > line 48: > >> 46: throw new RuntimeException("unexpected resource bundle"); >> 47: } >> 48: > > This main and TestPermission.java duplicate the basic resource location > mechanisms. > This test/Main.java an test/TestPermission can be removed entirely. Fixed in https://github.com/openjdk/jdk/pull/21498/commits/cb5f6e43b891df8c2a977e665016079469290669 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1820730316
