On Mon, 14 Oct 2024 08:25:49 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This dependency is primarily going to be used to test the generated >> documentation. >> >> This patch is meant to be integrated before #21272. >> >> Note: we need to be a very specific revision of `tidy` and cannot use any of >> the available artifacts, as older versions do not recognize some HTML 5 >> elements. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > - provide tidy to linux-aarch64. > - add condition to module name for tidy > - add new condition when passing the path to tidy I've added the missing platform, set a `TIDY_HOME` as the `enviroment_name` as was suggested in the first round of review. I've also added a new necessary condition to `make/RunTests.gmk`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21341#issuecomment-2410421076
