On Tue, 15 Oct 2024 15:28:49 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This dependency is primarily going to be used to test the generated
>> documentation.
>>
>> This patch is meant to be integrated before #21272.
>>
>> Note: we need to be a very specific revision of `tidy` and cannot use any of
>> the available artifacts, as older versions do not recognize some HTML 5
>> elements.
>>
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove check in RunTests.gmk, different approach.
> Remove environment_name TIDY_HOME
make/RunTestsPrebuiltSpec.gmk line 182:
> 180: ifneq ($(TIDY_HOME), )
> 181: TIDY := $(TIDY_HOME)/bin/tidy
> 182: endif
Unless TIDY_HOME is a well established variable in the context of Tidy, which I
doubt, then I think this isn't needed anymore. We aren't setting this from
jib-profiles.js, and I can't think of any other place this would be set. We
should export `TIDY` as an environment variable in the `run-test-prebuilt-docs`
profile in the other PR though.
make/conf/jib-profiles.js line 1283:
> 1281: revision: "5.9.20+1",
> 1282: environment_path: input.get("tidy", "home_path") +
> "/bin/tidy",
> 1283: configure_args: "TIDY=" + input.get("tidy", "home_path")
> +"/bin/tidy",
Suggestion:
configure_args: "TIDY=" + input.get("tidy", "home_path") +
"/bin/tidy",
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1801654736
PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1801653215
