On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on MacOS. > > Tested: with patch fastdebug and release builds are green again. Looks ok, though I would recommend switching to ifeq (string1, string2) and dropping the quotes around -O1 ------------- Marked as reviewed by jwaters (Committer). PR Review: https://git.openjdk.org/jdk/pull/21119#pullrequestreview-2320855574