On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on MacOS. > > Tested: with patch fastdebug and release builds are green again. I think we typically don't use that sort of syntax in make for ifeq, and the quotes around the -O1 shouldn't be necessary too, unless I've missed something. There might be a better way of implementing the check of whether Xcode 16 is being used, but since this is a workaround I think this is ok, we probably wouldn't want to overengineer a hack. My only concern is whether specifying -O1 directly like that will properly end up behind all other optimization flags to properly override them. Other than that, this looks ok ------------- PR Comment: https://git.openjdk.org/jdk/pull/21119#issuecomment-2366726184
