On Sun, 22 Sep 2024 11:56:48 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> Please be more specific. What is "that sort of syntax" you disapprove of? I was referring to the fact that we typically do ifeq (string1, string2) in Makefiles rather than ifeq "string1" "string2" (I probably should have used the GitHub code review feature), was the quote syntax needed for this patch? > You are saying that this override mechanism in itself is flawed? If so, it is > outside the scope of this RFE and you would need to open a separate JBS issue > to address this. For this RFE, I use this mechanism since it has been used > for many similar cases (see the other overrides in this file) and it makes my > build function again. Oh, don't mind that, I was just thinking out loud about LTO, I wasn't implying that the mechanism is flawed. Certain areas of the JDK don't have LTO in mind, maybe it's time I looked into that. Either way, I wasn't implying anything was wrong with your patch here > If its okay, would you mind approving, then? Right, I'll do that in a second. My approval won't really do you much good though :P > As I wrote originally: the patch was tested and it works. Moreover, this > seems to be the way to do per-file cflag optimization level overrides. That good to hear (I'll look back into SetupNativeCompilation to see if a cleaner way exists, but that's for another PR). Alright, will approve ------------- PR Comment: https://git.openjdk.org/jdk/pull/21119#issuecomment-2366788250
