On 10/01/2019 16:29, Sergey Poznyakoff wrote:
Hi Harald,
The abort() in src/extract.c's maybe_recoverable(), marked with a
comment as unreachable, is in fact reachable in this case.
Thanks for reporting. The erroneous abort() call was introduced by
commit ccef8581b8673cadd1c084595de4efde956c3c2b. I have reverted it.
Thanks for fixing it. You have let it fall through though, but it isn't
supposed to, is it? That's why I suggested putting a break statement
there. If you don't get ENOENT, there is no point in attempting to
create intermediate directories: it will never do anything, since all
directories exist already. Or am I misunderstanding? At the same time,
since it will never do anything, even if it is pointless, it is also
harmless.
Cheers,
Harald van Dijk
