Hi! Andreas Enge <andr...@enge.fr> skribis:
> The attached patch adds psutils. Its license is homebrewed: > http://packages.debian.org/changelogs/pool/main/p/psutils/current/copyright > Does it qualify as "bsd-like"? It looks like BSD-3 to me, or at least “BSD-like”. > If not, would it make sense to add a license "other" to licenses.scm, > which takes the same parameters as "bsd-like"? I think (guix licenses) should export the constructor, but under the name ‘make-license’ to avoid clashes with the ‘license’ field in ‘package’ records. > + (substitute* "Makefile" > + (("/usr/local/bin/perl") (string-append perl "/bin/perl"))) Please align the opening paren under the ‘u’. (Perhaps your editor can be tought to always do that?) > + (substitute* "Makefile" > + ((" install.include") "")) > + ;; drop installation of non-free files > + )) Please put the comment above the line it refers to, and move closing parentheses to the end of the line. Nitpickingly yours, ;-) Ludo’.
