crc-x86_64 is added as its own package with minimal bindings in crc.c to support, flagged off by the GL_CRC_PCLMUL flag which is only set if the crc-x86_64 package is selected.
Tested against gzip with the package included and omitted and gzip builds fine in both case. On Fri, 13 Dec 2024 at 20:40, Sam Russell <sam.h.russ...@gmail.com> wrote: > Sounds good, thanks for explaining. I'll get going on the autoconf stuff > then. > > On Fri, Dec 13, 2024, 20:03 Jim Meyering <j...@meyering.net> wrote: > >> That's not the way it usually works. >> Typically, the author and/or person most familiar with the code is >> listed as the Maintainer. >> If you don't want to list yourself and no one else steps up, just mark >> it as "all". >> >> On Fri, Dec 13, 2024 at 10:52 AM Sam Russell <sam.h.russ...@gmail.com> >> wrote: >> > >> > Jim, would you be willing to be the maintainer for this in gnulib? If >> so then I can fix the autoconf this week and get it ready to go >> > >> > On Fri, Dec 13, 2024, 19:29 Jim Meyering <j...@meyering.net> wrote: >> >> >> >> As soon as this is added to gnulib, I'll be happy to prepare for a new >> >> gzip release that includes it. >> >> >> >> On Fri, Dec 13, 2024 at 9:45 AM Sam Russell <sam.h.russ...@gmail.com> >> wrote: >> >> > >> >> > I should also add that I'm planning long term to try and get the >> major open source tools (e.g. gzip) using the most efficient algorithms for >> CRC32, so there will be more patches coming in future to match the ones >> I've submitted to coreutils. Are there any volunteers to be maintainer for >> these? >> >> > >> >> > On Fri, Dec 13, 2024, 17:52 Sam Russell <sam.h.russ...@gmail.com> >> wrote: >> >> >> >> >> >> > I'd prefer of the crc PCLMUL feature is "opt-in" from a package >> >> >> > maintainer point of view. >> >> >> >> >> >> fine by me, this just requires a change to the build script then? >> the binding in crc.c has #ifdefs around it already >> >> >> >> >> >> > So this would be removed. >> >> >> >> >> >> ok, so we just need crc pclmul to be explicitly flagged on by a >> downstream maintainer to make it work? I'll look into how to make that work >> >> >> >> >> >> > Add yourself as maintainer of the new module please :) >> >> >> >> >> >> I can't commit to being a maintainer, but I can commit to being >> available for a few months in the case of any bugs arising. My goal here is >> improving the speed of gzip, would it be a better bet to work directly with >> them to get it included there? >> >> >> >> >
0001-crc-Add-PCLMUL-implementation.patch
Description: Binary data
