Thanks - I have pushed this now. Sam Russell <sam.h.russ...@gmail.com> writes:
>> I'm unsure about those CFLAGS. Aren't these CFLAGS required when
>> building the code too? If not, why can't the same pattern to detect
>> PCLMUL during ./configure which is done during run-time?
>
> discussed with Bruno earlier in the thread, CFLAGS set this for the entire
> build so we've done it with pragmas inside crc-x86_64-pclmul.c
My point was that it would be better to use the same mechanism the .c
implementation uses in the ./configure check, to make sure it tests for
what will be used. That is, drop the CFLAGS changes and add:
#pragma GCC push_options
#pragma GCC target("pclmul,avx")
...
#pragma GCC pop_options
/Simon
signature.asc
Description: PGP signature
