Hi Dago, Thanks for the analysis.
On Sep 23, 2013, at 10:07 PM, Dagobert Michelsen <dagob...@familie-michelsen.de> wrote: > I didn't enable gcc-warnings, but as it turns out this flag is automatically > enabled when $srcdir/.git is present: > > AC_ARG_ENABLE([gcc-warnings], > [AS_HELP_STRING([--enable-gcc-warnings], > [turn on lots of GCC warnings (for developers)])], > [case $enableval in > yes|no) ;; > *) AC_MSG_ERROR([bad value $enableval for gcc-warnings option]) ;; > esac > gl_gcc_warnings=$enableval], > [if test -d "$srcdir"/.git; then > gl_gcc_warnings=yes > else > gl_gcc_warnings=no > fi] > ) Ugh, I didn't even notice that had arrived since 1.4.16: http://git.savannah.gnu.org/gitweb/?p=m4.git;a=commit;h=2fdc2f744de4365b8cafc962f6ccbbb03640358e Clearly, it should at least check whether the compiler is actually gcc before piling on the flags, although I don't think it is serious enough to warrant another release. Eric, do you mind if I revert that change in branch-1.4 in case of a 1.4.18 in future? > However, when I browse git the automatic detection of .git is not in there: > > http://git.savannah.gnu.org/gitweb/?p=m4.git;a=blob;f=configure.ac;h=2fe6d9e8189d4083b58ba10bfbbe558da15f393b;hb=c09a187c50f2f74e89d4d0991bdbd2c6846cc707 That's a link to master, which is where 2.0 is being polished. But 1.4.17 was cut from branch-1.4. > By coincidence we use git to apply patches in our build system > to upstream sources if necessary, so this is the thing that > confuses the build. I suggest you add a patch to revert the changeset I linked above, or configure your build system to pass --disable-gcc-warnings as suggested in the commit log. > When I disable using git in our buildsystem > the compilation works fine. I would prefer a system that enabled flags > explicitly and not by inspecting side effects but I can understand the > current behaviour. Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)
signature.asc
Description: Message signed with OpenPGP using GPGMail
