On 09/23/13 08:40, Eric Blake wrote: > -fdiagnostics-show-option is very useful for gcc; perhaps we > should tweak m4/manywarnings.m4 to add it to the set of warnings probed > by default when gcc warnings are enabled
I'm not familiar with that option. Isn't it the default behavior for GCC nowadays? > maybe it's sufficient to change gl_COMPILER_OPTION_IF > to use AC_LINK_IFELSE instead of AC_COMPILE_IFELSE? Yes, thanks, that fixes the problem for me. I pushed this patch into gnulib: >From ab166f90fc84e0540e04836a626d2cc2afc91f77 Mon Sep 17 00:00:00 2001 From: Paul Eggert <egg...@cs.ucla.edu> Date: Mon, 23 Sep 2013 10:16:13 -0700 Subject: [PATCH] warnings: port --enable-gcc-warnings to Solaris Studio 12.3 Problem reported by Dagobert Michelsen via Eric Blake in <http://lists.gnu.org/archive/html/bug-gnulib/2013-09/msg00052.html>. * m4/warnings.m4 (gl_COMPILER_OPTION_IF): Use AC_LINK_IFELSE, not AC_COMPILE_IFELSE. --- ChangeLog | 8 ++++++++ m4/warnings.m4 | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3288c7c..a963098 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2013-09-23 Paul Eggert <egg...@cs.ucla.edu> + + warnings: port --enable-gcc-warnings to Solaris Studio 12.3 + Problem reported by Dagobert Michelsen via Eric Blake in + <http://lists.gnu.org/archive/html/bug-gnulib/2013-09/msg00052.html>. + * m4/warnings.m4 (gl_COMPILER_OPTION_IF): Use AC_LINK_IFELSE, + not AC_COMPILE_IFELSE. + 2013-09-23 Eric Blake <ebl...@redhat.com> configmake: support new --runstatedir option diff --git a/m4/warnings.m4 b/m4/warnings.m4 index 5f5da51..e3d239b 100644 --- a/m4/warnings.m4 +++ b/m4/warnings.m4 @@ -1,4 +1,4 @@ -# warnings.m4 serial 10 +# warnings.m4 serial 11 dnl Copyright (C) 2008-2013 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -36,9 +36,9 @@ AC_CACHE_CHECK([whether _AC_LANG compiler handles $1], m4_defn([gl_Warn]), [ gl_save_compiler_FLAGS="$gl_Flags" gl_AS_VAR_APPEND(m4_defn([gl_Flags]), [" $gl_unknown_warnings_are_errors ]m4_defn([gl_Positive])["]) - AC_COMPILE_IFELSE([m4_default([$4], [AC_LANG_PROGRAM([])])], - [AS_VAR_SET(gl_Warn, [yes])], - [AS_VAR_SET(gl_Warn, [no])]) + AC_LINK_IFELSE([m4_default([$4], [AC_LANG_PROGRAM([])])], + [AS_VAR_SET(gl_Warn, [yes])], + [AS_VAR_SET(gl_Warn, [no])]) gl_Flags="$gl_save_compiler_FLAGS" ]) AS_VAR_IF(gl_Warn, [yes], [$2], [$3]) -- 1.8.3.1
