On Mon, 10 Dec 2001 22:03, Leif Mortenson wrote: > Peter Donald wrote: > >On Sun, 9 Dec 2001 20:41, Leif Mortenson wrote: > >>Thanks, I appreciate the kudos. I have actually already implemented a > >>class which launches Phoenix using the Wrapper. I was planning to > >>submit it after I found out you whether you would implement the changes > >>I suggested and I finished testing it. I'll go over yours and my > >>implementations on Monday when I have the code in front of me and let > >>you know if I have any suggested changes. > > > >kool. I copied bits from the ENhydra example so there may be bits that > > make no sense - feel free to point them out (specifically thinking about > > the timeout stuff around the initialization/start methods). > > Ok, here we go. :-)
;) > In the wrapper.conf, file, you have added all of the Phoenix jar files > to the classpath. You don't need this because Phoenix finds and loads > all of the classes in the lib directory when it is running. You only > need the following: > wrapper.java.classpath.1=phoenix-loader.jar > wrapper.java.classpath.2=wrapper.jar yep. > I saw that you had the following line in the wrapper.conf file: > #wrapper.java.additional.1=-Dwrapper.debug=true > That will work, but the way we had designed it was to use the > wrapper.debug property in wrapper.conf to toggle this. :-) Legacy ;) By the time I figured out that I could specify it in the conf file I had already gone through the sourcode to WrapperManager to figure out how to turn on debugging ;) > The run.bat script currently sets the following 4 parameters when it > launches Java. Currently if I set all four then I get security > violations. I will try to look into that sometime this week. > I am attaching the new src/conf/wrapper.conf. will have a look at. > For the DaemonLauncher, I am sending you the version that I had written. Are you sure you are sending it ? I never saw anything attached ;) > It was coded so that it treats class loaders etc exactly like the Main > class does. It also handles error cases while starting much better. > This version does not use an ActionListener. But it does set the > thread's class loader like Main does. Okay - the one I did just called Main so it should do that aswell ;) > This version also kicks out debug information when wrapper.debug is > enabled. ok. > Could you give this version a try and see how you like it. as soon as yer send it - will do. > We were also talking about how to implement the change user feature that > you(?) requested. yep. >It should be easy to do, but the user really needs to > be set after the application, in this case Phoenix, is completely up and > running. The problem is that because CLIMain.main never returns, there > is currently no way to tell whether Phoenix has completed its startup or > not. yep. I ran into this "issue" aswell. > There are 4 ways we can make this work. > One is for CLIMain.main to return when setup is complete. (Hard to do?) This means we essentially spawn a thread to do the execute() part. Easy enough to do and something I have to do anyway for something else I am working on. > In the ant.properties.sample file, could you please change the wrapper > definitions to the following: will do. > One more thing, is about the scripts used to launch Phoenix using the > wrapper. It doesn't look like they are being included in the > wrapper-dist build right now. It is fairly easy to start and stop the > windows version without a batch file, but the scripts for the unix > versions provide the ability to start and stop them without having to > hit CTRL-C. Useful for when you want to install Phoenix as a daemon on > the system. ok. > It doesn't look like there is any plaform specific code in the current > build.xml, but it is fairly easy to add checks for the platform so that > the correct scripts are copied into the dist/bin directory for each > platform. > > Let me know what you think, and I can make the changes for you. patches gladly accepted ;) -- Cheers, Pete "abandon all hope , ye who enter here" - dante, inferno -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
