Re: Propper way to shut down avalon.

[Leif Mortenson]

Peter Donald wrote:
On Fri, 7 Dec 2001 18:03, Leif Mortenson wrote:
I manage a SourceForge project, http://wrapper.sourceforge.net , that
does this. It currently has 2.2.2 released, but the changes I have made
to get it working with Phoenix are still being finalized.  Release 2.2.3
with those changes should be up in a few days.  I will post again when
it is.
I just downloaded it and it is great! I adapted the classes as you suggested 
and added a simple object that implements WrapperListener. It works great!

Thanks, I appreciate the kudos.  I have actually already implemented a 
class which launches Phoenix using the Wrapper.  I was planning to 
submit it after I found out you whether you would implement the changes 
I suggested and I finished testing it.  I'll go over yours and my 
implementations on Monday when I have the code in front of me and let 
you know if I have any suggested changes.

I am amazed that you got it working so quickly.  This is the first 
project that I have gotten feedback on.  (Lots of downloads though)

To make this work correctly, the shutdown() method would also have to
deregister the shutdown hook when it was called. 

I actually didn't do this as some JVMs will die a horrible death if you try 
to deregister a shutdown hook after any of shutdown hooks have started. 
However I nulled out m_hook and if it is null we skip it during 
forcedShutdown()

I think mine worked for the Phoenix shutdown hook because the 
forceShutdown method was setting the hook to null then the shutdown 
method was only deregistering if it was not null, but I guess it is 
possible that another hook could have been started.  Looks good.


Would it be possible to have debugging levels for the native code. As I spent 
a while debugging something in the config files (a stupid typo). However if I 
had been able to turn on debugging and see the command line produced by the 
program I would have figured it out straight away. As it was I went in and 
littered your code with debugging output ;)

Looks like you figured this out from a later post.  But it is the 
wrapper.debug property in the wrapper.conf file.  I will add something 
to docs to make this more obvious.

Could you also add something like
    <fixcrlf srcdir="${bin.dist.dir}" includes="**/*.bat" eol="crlf" />
    <fixcrlf srcdir="${bin.dist.dir}" includes="**/*.sh" eol="lf" />
to your build file. As the distributions on the website have windows line 
endings in all the unix commands and thus they fail.

Done.  Sorry about that.  Our testing didn't include exchanging releases 
build on different platforms. oops.

I am also fixing it so that the other source files in the .zip src files 
use "crlf" and the .tar.gz files use "lf".

I also changed it so that the source builds do not include built batch 
or script files.

It would also be nice to 
make all the shell scripts executable in the tar file by doing something like

<tar longfile="gnu" tarfile="${dist.base}/${dist.name}-bin.tar">
  <tarfileset dir="${dist.name}/.." mode="755"> <!-- notice mode here -->
        <include name="${dist.name}/**/*.sh"/>
      </tarfileset> 
      <tarfileset dir="${dist.name}/.."> 
        <exclude name="${dist.name}/**/*.sh"/>
      </tarfileset> 
    </tar>

Binary builds now do this.  (Still need to test this though.)

It would also be useful to not have to place some variables into the config 
file such as the java command. Instead they could be passed in while starting 
up wrapper?

I want to think a little about how to implement this.  If you have any 
comments, the issue is at:
http://sourceforge.net/tracker/index.php?func=detail&aid=490791&group_id=39428&atid=425190


Also if you don't specify a config file it may be useful to not do any 
logging at all. I couldn't figure out if there was a way to turn off logging?

Not currently. (see below)  You actually always need to have a config 
file as that is how the wrapper figures out what to do.


Also it would be great to be able to remove the prefix from the logging 
output via a command line option or something ;)

I described a way of doing this at:
http://sourceforge.net/tracker/index.php?func=detail&aid=490793&group_id=39428&atid=425190
This method would be quick and easy to implement.  I don't really want 
to try and make a full featured logging program.  Post any comments 
about it there as follow-ups.

Thanks for integrating this :-)  I am happy to see it being used.
Leif
--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>