Alexandre Oliva <[EMAIL PROTECTED]> wrote:
| On Mar 1, 2000, Jim Meyering <[EMAIL PROTECTED]> wrote:
|
| > Don't use `ln' (which was just a space optimization anyway)
|
| A worthwhile optimization, IMO. There are some `find' hacks in the
Worthwhile? Why? Sure it saves space for the `dist' rule, but not if you
also run the `distcheck' one, since that unpacks the resulting tgz file.
And at what expense? If we have to jump through hoops in writing and
maintaining (and documenting or remembering to watch out for) hacks that
are spread throughout automake.in and the generated Makefiles, then maybe
it's better to spend a little more time doing copies instead of links.
Maintainers shouldn't have to worry about this `gotcha'.
| `dist' rules to avoid modifying the permissions in the source tree,
| but, unfortunately, they do not apply to the final `chmod -R a+w' at
| the end of `dist' or `dist-all', nor to the beginning of `distcheck' or
| `distdir'. We should probably replace:
|
| -chmod -R a+w $(distdir) > /dev/null 2>&1; rm -rf $(distdir)
|
| with:
|
| -find $(distdir) -type d -exec chmod a+w {} \; ; rm -rf $(distdir)
That'd be ok if there were a compelling reason to continue using such
hacks, but in any case, please don't advocate use of -exec in cases
like this. Using xargs is more efficient:
-find $(distdir) -type d |xargs chmod a+w; rm -rf $(distdir)
| And it would fix the whole problem without disabling the
| optimization. Note that distcheck applies several other chmod to
| distdir, but only after it is created from scratch, in a
| hard-link-free way, by extracting the sources from the dist file.
