Paul makes a critical point here. Just casting to make warnings go away is almost always a bad idea. Digging into the reason for the warning is what you want to do.
Thanks! On Sun, Jan 12, 2025 at 11:01 AM Paul Lalonde <paul.a.lalo...@gmail.com> wrote: > > > > On Sun, Jan 12, 2025 at 10:02 AM <tlaro...@kergis.com> wrote: >> >> [I have made a first PR for some small fixes to nix/nix >> and adding a NOTES that fixes some infelicities in the >> instructions to get started] > > > Thank you! Infelicities is a very polite way to point out my poor > note-taking skills! > >> >> Would it be possible to gather the (modification) bits together, for >> example in sys/src/nix/rc, mounted via (nix/nix) in order to appear >> as nix/vmx, nix/mkusbkey and so long, in order to put the pieces >> together? > > > Yes, this is a great suggestion. Please do! > >> >> Note: there are a number of warnings when compiling so my next >> assignment will be to fix the compiler (assembler, compiler, linker) >> warnings before tracking panics. I prefer to grasp the easier task at >> hand ;-^ > > > I'll admit to punting on these. > > Most of them are from parameter and signature changes from long to size, and > each requires careful examination and analysis to understand if > sign-extending is sufficient/appropriate, and whether the size change should > propagate through more of the neighboring code. Most important is to avoid > any casting to quiet the compiler since it is telling us something useful. > > Paul > > 9fans / 9fans / see discussions + participants + delivery options Permalink ------------------------------------------ 9fans: 9fans Permalink: https://9fans.topicbox.com/groups/9fans/Ted30b22de106b2db-Mf76543b59e2ff08ea66838bb Delivery options: https://9fans.topicbox.com/groups/9fans/subscription
