Hi I had a quick look. Looks great!
A suggestion - From given example, I think API could be made more "pythonic". Python is dynamically typed and properties can be dynamically looked up too. Thus, instead of prop_get_* we can have - 1. prop() : generic function, returning "typed" arguments. The builtin zfs properties would be returned with correct "type" and user properties would be returned as generic string. 2. Ability to just say "z.property_name" (eg. z.compression). This would be trivial to implement syntactic sugar. Also, some work would be needed to provide "pythonic" iterators and other idioms so that API does not feel like a python interface to C. Thanks - Akhilesh This message posted from opensolaris.org _______________________________________________ zfs-discuss mailing list zfs-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
