Hi Maxin,
> -----Original Message-----
> From: Maxin B. John [mailto:maxin.j...@enea.com]
> Sent: Monday, September 08, 2014 11:16 AM
> To: Vladimir Redzhepov
> Cc: yocto@yoctoproject.org; Pavel Shumeika
> Subject: Re: [meta-oracle-java][PATCH] Add support for Java SE Embedded
>
> Hi Vladimir,
>
> On Fri, Sep 05, 2014 at 03:58:53PM +0000, Vladimir Redzhepov wrote:
> > >From 783ff400987ec06f41286ffce7e3afc4545d67e5 Mon Sep 17 00:00:00
> 2001
> > From: Vladimir Redzhepov <vladimir_redzhe...@epam.com>
> > Date: Fri, 5 Sep 2014 18:13:42 +0300
> > Subject: [PATCH] Add support for Java SE Embedded
> >
> > LICENSE file removed from LIC_FILES_CHKSUM in oracle-jse.inc
> > because it doesn't exist in ejre.
>
> Can we avoid removing the LICENSE file from oracle-jse.inc ?
Removing the LICENSE could be avoided by overriding LIC_FILES_CHKSUM in
oracle-jse-ejre.inc like this
LIC_FILES_CHKSUM = "\
file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/COPYRIGHT;md5=be9fe5d47a7dcfb78f142f487afb34bb
\
file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/THIRDPARTYLICENSEREADME.txt;md5=f3a388961d24b8b72d412a079a878cdb
\
"
In my mind it's better to keep and update all checksums in one place such
oracle-jse.inc which is common for all recipes.
>
> > Signed-off-by: Vladimir Redzhepov <vladimir_redzhe...@epam.com>
> > ---
> > .../oracle-jse-ejre-arm-vfp-hflt-client-headless_1.7.0.bb | 9 +++++++++
> > recipes-devtools/oracle-java/oracle-jse-ejre.inc | 12
> > ++++++++++++
> > recipes-devtools/oracle-java/oracle-jse.inc | 1 -
> > 3 files changed, 21 insertions(+), 1 deletion(-)
> > create mode 100644 recipes-devtools/oracle-java/oracle-jse-ejre-arm-vfp-
> hflt-client-headless_1.7.0.bb
> > create mode 100644 recipes-devtools/oracle-java/oracle-jse-ejre.inc
> >
> > diff --git
> > a/recipes-devtools/oracle-java/oracle-jse-ejre-arm-vfp-hflt-client-
> headless_1.7.0.bb b/recipes-devtools/oracle-java/oracle-jse-ejre-arm-vfp-
> hflt-client-headless_1.7.0.bb
> > new file mode 100644
> > index 0000000..bfa8011
> > --- /dev/null
> > +++ b/recipes-devtools/oracle-java/oracle-jse-ejre-arm-vfp-hflt-client-
> headless_1.7.0.bb
> > @@ -0,0 +1,9 @@
> > +PV_UPDATE = "60"
> > +BUILD_NUMBER = "19"
> > +
> > +require oracle-jse-ejre.inc
> > +
> > +SRC_URI =
> "http://download.oracle.com/otn/java/ejre/7u${PV_UPDATE}-
> b${BUILD_NUMBER}/ejre-7u${PV_UPDATE}-fcs-b${BUILD_NUMBER}-linux-
> arm-vfp-hflt-client_headless-07_may_2014.tar.gz"
> > +
> > +SRC_URI[md5sum] = "b9b8f598b0a7f49e4d221f16ba25c6c0"
> > +SRC_URI[sha256sum] =
> "ed061060011d88efe5563c2949c00993db85db17ab94f18a78713007a2b90faf"
> > diff --git a/recipes-devtools/oracle-java/oracle-jse-ejre.inc b/recipes-
> devtools/oracle-java/oracle-jse-ejre.inc
> > new file mode 100644
> > index 0000000..4eeace0
> > --- /dev/null
> > +++ b/recipes-devtools/oracle-java/oracle-jse-ejre.inc
> > @@ -0,0 +1,12 @@
> > +SUMMARY = "Oracle Java SE runtime environment binaries"
> > +DESCRIPTION = "This is the proprietary JRE from Sun/Oracle, with the
> Hotspot JVM. It is\
> > + provided by Sun/Oracle only in binary format.\
> > + Java Platform, Standard Edition (Java SE) lets you develop and deploy
> Java\
> > + applications on desktops and servers, as well as in today's demanding\
> > + embedded environments. Java offers the rich user interface,
> performance,\
> > + versatility, portability, and security that today's applications require.\
> > + The JRE (Java Runtime Environment) is needed on a system to run Java\
> > + applications and applets"
> > +
> > +JDK_JRE = "ejre"
> > +require oracle-jse.inc
> > diff --git a/recipes-devtools/oracle-java/oracle-jse.inc b/recipes-
> devtools/oracle-java/oracle-jse.inc
> > index 38ceef0..5aebfaf 100644
> > --- a/recipes-devtools/oracle-java/oracle-jse.inc
> > +++ b/recipes-devtools/oracle-java/oracle-jse.inc
> > @@ -1,7 +1,6 @@
> > LICENSE_FLAGS = "oracle_java"
> > LICENSE = "Oracle_Binary_Code_License_Agreement"
> > LIC_FILES_CHKSUM = "\
> > -
> file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/LICENSE;md5=9
> 8f46ab6481d87c4d77e0e91a6dbc15f \
> >
> file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/COPYRIGHT;md
> 5=be9fe5d47a7dcfb78f142f487afb34bb \
> >
> file://${WORKDIR}/${JDK_JRE}${PV}_${PV_UPDATE}/THIRDPARTYLIC
> ENSEREADME.txt;md5=f3a388961d24b8b72d412a079a878cdb \
> > "
> > --
>
> Otherwise, looks ok.
>
> Best Regards,
> Maxin
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
