Reviewed: https://review.opendev.org/c/openstack/neutron/+/940687
Committed:
https://opendev.org/openstack/neutron/commit/a962fc636b7b3c410633a34aa0c6a146a60a8acd
Submitter: "Zuul (22348)"
Branch: master
commit a962fc636b7b3c410633a34aa0c6a146a60a8acd
Author: Rodolfo Alonso Hernandez <ralon...@redhat.com>
Date: Tue Feb 4 10:23:00 2025 +0000
[FT] Relax the active wait period in ``TestAsyncProcess``
The active wait in ``test_async_process_respawns*`` methods is too
demanding with a sleep period of only 0.01 seconds. This patch relaxes
this period to 0.2 seconds, allowing the system to process other threads
like for example the ``AsyncProcess._watch_process`` that is being
tested.
Closes-Bug: #2097284
Closes-Bug: #2095598
Change-Id: I1d60aed1bc56ee2619f639a68362fd357ef08ea8
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2097284
Title:
test_async_process_respawns_with_race_condition functional test fails
randomly
Status in neutron:
Fix Released
Bug description:
It's a new test recently added with
https://review.opendev.org/c/openstack/neutron/+/939627 and failing randomly
as:-
ft1.3:
neutron.tests.functional.agent.linux.test_async_process.TestAsyncProcess.test_async_process_respawns_with_race_conditiontesttools.testresult.real._StringException:
traceback-1: {{{
Traceback (most recent call last):
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/linux/test_async_process.py",
line 47, in _safe_stop
proc.stop()
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/agent/common/async_process.py",
line 158, in stop
self._kill(kill_signal, kill_timeout)
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/agent/common/async_process.py",
line 209, in _kill
self._kill_process_and_wait(pid, kill_signal, kill_timeout)
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/agent/common/async_process.py",
line 223, in _kill_process_and_wait
self._process.wait(kill_timeout)
File
"/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.12/site-packages/eventlet/green/subprocess.py",
line 89, in wait
eventlet.sleep(check_interval)
File
"/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.12/site-packages/eventlet/greenthread.py",
line 45, in sleep
hub.switch()
File
"/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.12/site-packages/eventlet/hubs/hub.py",
line 310, in switch
return self.greenlet.switch()
^^^^^^^^^^^^^^^^^^^^^^
File
"/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.12/site-packages/eventlet/hubs/hub.py",
line 362, in run
self.wait(sleep_time)
File
"/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.12/site-packages/eventlet/hubs/poll.py",
line 80, in wait
presult = self.do_poll(seconds)
^^^^^^^^^^^^^^^^^^^^^
File
"/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.12/site-packages/eventlet/hubs/epolls.py",
line 31, in do_poll
return self.poll.poll(seconds)
^^^^^^^^^^^^^^^^^^^^^^^
File
"/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.12/site-packages/fixtures/_fixtures/timeout.py",
line 52, in signal_handler
raise TimeoutException()
fixtures._fixtures.timeout.TimeoutException
}}}
Traceback (most recent call last):
File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py",
line 178, in func
return f(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/linux/test_async_process.py",
line 91, in test_async_process_respawns_with_race_condition
self.test_async_process_respawns()
File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py",
line 178, in func
return f(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/linux/test_async_process.py",
line 76, in test_async_process_respawns
common_utils.wait_until_true(
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/common/utils.py", line
733, in wait_until_true
raise exception if exception else WaitTimeout(
RuntimeError: Async process didn't respawn
Example failure:-
https://dd6f60029ec5db46bbe6-31bf408f42c27b0363a3847bc2706cfc.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/neutron/master/neutron-functional-with-oslo-master/c3ee78c/testr_results.html
https://cc3bae51b52e758d86cc-97cd64a1f5863f7dd8ea666bcc4ee7bd.ssl.cf5.rackcdn.com/939451/5/gate/neutron-functional/e853389/testr_results.html
Opensearch:-
https://opensearch.logs.openstack.org/_dashboards/app/data-explorer/discover#?_a=(discover:(columns:!(_source),isDirty:!f,sort:!()),metadata:(indexPattern:'94869730-aea8-11ec-9e6a-83741af3fdcd',view:discover))&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-30d,to:now))&_q=(filters:!(),query:(language:kuery,query:'message:%22in%20test_async_process_respawns_with_race_condition%22'))
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2097284/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
