Reviewed: https://review.opendev.org/c/openstack/neutron/+/939542
Committed:
https://opendev.org/openstack/neutron/commit/47718064b70bf2f09b23e294fd5ec04851aa7b67
Submitter: "Zuul (22348)"
Branch: master
commit 47718064b70bf2f09b23e294fd5ec04851aa7b67
Author: Ihar Hrachyshka <ihar.hrachys...@gmail.com>
Date: Fri Jan 17 10:38:01 2025 -0500
tests: Don't assume update outside ovs txn notifies separately from create
Closes-Bug: #2095180
Change-Id: I776269a5c283ce9da69613a377f80e1a0d54bb3d
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2095180
Title:
test_agent_metadata_port_dhcp_reenable_event fails when ovsdb-server
combines create and later update into a single create event for
monitor
Status in neutron:
Fix Released
Bug description:
https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_94a/939272/2/check/neutron-
functional/94afc30/testr_results.html
ft1.4:
neutron.tests.functional.agent.ovn.metadata.test_metadata_agent.TestMetadataAgent.test_agent_metadata_port_dhcp_reenable_eventtesttools.testresult.real._StringException:
Traceback (most recent call last):
File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py",
line 178, in func
return f(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File
"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/ovn/metadata/test_metadata_agent.py",
line 385, in test_agent_metadata_port_dhcp_reenable_event
self.assertTrue(mdt_pb_event.wait())
File "/usr/lib/python3.12/unittest/case.py", line 727, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true
The failure is because the test expects an update. The code of the
test case creates a LSP in a transaction, then updates its external-
ids - outside of this transaction. ovsdb-server is allowed to combine
updates into one though - so in this failure we receive a single
insert instead of two events.
The fix is to update the external-ids as desired under the same ovsdb
transaction.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2095180/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
