Reviewed: https://review.opendev.org/c/openstack/os-vif/+/923036
Committed:
https://opendev.org/openstack/os-vif/commit/99814b280fbdf8169d291e003cf6dc5a80e08074
Submitter: "Zuul (22348)"
Branch: master
commit 99814b280fbdf8169d291e003cf6dc5a80e08074
Author: Bence Romsics <bence.roms...@gmail.com>
Date: Tue Jun 25 15:52:23 2024 +0200
Do not add taps in trunk bridges to the dead vlan
When using neutron trunks, the tpi port is meant to be put in the dead
vlan, not the tap, therefore
1) we no longer add taps in trunk bridges to the dead vlan in order to
avoid bug #2069543.
While working on this I realized a related problem:
In neutron we changed how the dead vlan is handled. Instead of simply
setting tag=4095 we set (beyond having a drop rule for tag 4095):
tag : 4095
trunks : [4095]
vlan_mode : trunk
We do this not with the intention of making the port a trunk, but with
the intention of dropping all traffic arriving on the port. For details
please see the following patches:
neutron $ git log --oneline --no-merges --grep='dead vlan' -2
0ddca28454 Make sure "dead vlan" ports cannot transmit packets
7aae31c9f9 Make the dead vlan actually dead
Therefore 2) this patch also starts handling ports in the dead vlan as
neutron does.
Change-Id: I4f80d94bc1f346fd0a7ad0b9d684792f1451cf24
Closes-Bug: #2069543
Related-Bug: #1734320
Related-Bug: #1930414
Related-Bug: #1959564
** Changed in: os-vif
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2069543
Title:
instance tap port has dead vlan when parent port for trunk
Status in neutron:
In Progress
Status in os-vif:
Fix Released
Bug description:
zed release, version 21.2.1
i have not tried to reproduce on a newer version
when creating a trunk the tap interface for the instance is still in dead vlan
Bridge tbr-d0aed4fd-1
datapath_type: system
Port tbr-d0aed4fd-1
Interface tbr-d0aed4fd-1
type: internal
Port tap2f072c63-b6
tag: 4095
Interface tap2f072c63-b6
Port tpt-2f072c63-b6
tag: 0
Interface tpt-2f072c63-b6
type: patch
options: {peer=tpi-2f072c63-b6}
if I issue set tag=[] to force the tap port into being a trunk with:
ovs-vsctl set port tap2f072c63-b6 tag=[]
traffic starts to flow which makes me think the port binding for the
tap is not done correctly
logs: https://paste.opendev.org/show/bstDgfi43ManfW1RijJo/
trunk ID: d0aed4fd-193d-4164-ba48-7d1d137787e1
parent port ID: 2f072c63-b6ce-45d3-96b6-27b4f46d397b
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2069543/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
