Reviewed: https://review.opendev.org/c/openstack/neutron/+/934418
Committed:
https://opendev.org/openstack/neutron/commit/526f238fa47c8e66b4b3dd300b1630e3fc848619
Submitter: "Zuul (22348)"
Branch: master
commit 526f238fa47c8e66b4b3dd300b1630e3fc848619
Author: Rodolfo Alonso Hernandez <ralon...@redhat.com>
Date: Tue Nov 5 15:42:32 2024 +0000
[OVN] QoS max and min rules should be defined in LSP for phynet ports
The ML2/OVN QoS enforcement for physical network ports (flat, VLAN) is
done in the localnet port of the physical bridge via TC commands.
A physical network will have a physical bridge in each compute node.
This physical bridge will have a NIC interface that will provide
connectivity. On this interface (localnet port), OVN enforces the QoS
mininum and maximum rate rules (**only egress**), using TC commands
on the interface. It creates a HTB qdisc and a class per port with
QoS rules. Each class, that will match the traffic of the port, will
have a "ceil" and "rate" values [1].
OVN uses the information stored in the "Logical_Switch_Port.options"
field, stored as a dictionary, with the keys [2]:
* qos_min_rate
* qos_max_rate
* qos_burst
This patch is:
* Moving the max and min rate configuration from the QoS registers
to the "Logical_Switch_Port.options" dictionary.
* Logging a warning when a min rate option is defined in a port hosted
in a tunnelled network (not supported).
This change was documented in [3], in OVN version 23.06.0
[1]https://man7.org/linux/man-pages/man8/tc-htb.8.html
[2]https://github.com/ovn-org/ovn/blob/1bec9e3ddd8500793b52e11c3dc1f41ef1f48591/ovn-nb.xml#L1155-L1168
[3]https://github.com/ovn-org/ovn/commit/87514ac04271e87c3ad011599378d22ab6bed43c
Closes-Bug: #2015376
Change-Id: I4581d31ba04c0d2f3f45ee6d07bcaba82fb038d4
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2015376
Title:
[OVN] min-BW rule, defined in the LSP.options field, must be
accompanied with a max-BW value
Status in neutron:
Fix Released
Bug description:
The QoS values defined in the LSP.options field are directly translated to a
TC command and set in the interface. There are 3 values [1]:
* qos_min_rate
* qos_max_rate
* qos_burst
Neutron is currently using "qos_min_rate" only. The max-BW and DSCP
QoS rules are defined with QoS registers that match an input/output
port traffic.
As specified in [2], the "rate" parameter ("qos_max_rate") is
mandatory. The "ceil" parameter ("qos_min_rate") is not. Neutron needs
to provide a default "qos_max_rate" for any port where "qos_min_rate"
is configured (as commented, we are only using "qos_min_rate").
Jira ticket: https://issues.redhat.com/browse/OSPRH-11035
[1]https://github.com/ovn-org/ovn/blob/1bec9e3ddd8500793b52e11c3dc1f41ef1f48591/ovn-nb.xml#L1155-L1168
[2]https://man7.org/linux/man-pages/man8/tc-htb.8.html
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2015376/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
