Reviewed: https://review.opendev.org/c/openstack/nova/+/929858
Committed:
https://opendev.org/openstack/nova/commit/15dccaeed3cd0cc5a4283ec66d7347becabb64df
Submitter: "Zuul (22348)"
Branch: master
commit 15dccaeed3cd0cc5a4283ec66d7347becabb64df
Author: Amit Uniyal <auni...@redhat.com>
Date: Wed Sep 18 23:19:15 2024 +0000
Update Nova bdm with updated swap info
This change updates bdm for swap in finish_resize and revert_resize
functionality.
Change also adds supporting:
- unit and functional tests
- docs: releasenote
Closes-Bug: #1552777
Change-Id: Ic8aaa0728a43936cd4c6e1ed590e01ba8f0fbf5b
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1552777
Title:
resizing from flavor with swap to one without swap puts instance into
Error status
Status in OpenStack Compute (nova):
Fix Released
Bug description:
In a single-node devstack (current trunk, nova commit 6e1051b7), if
you boot an instance with a flavor that has nonzero swap and then
resize to a flavor with zero swap it causes an exception. It seems
that we somehow neglect to remove the swap file from the instance.
2016-03-03 10:02:41.415 ERROR nova.virt.libvirt.guest
[req-dadee404-81c4-46de-9fd5-58de747b3b78 admin alt_demo] Error launching a
defined domain with XML: <domain type='kvm'>
<name>instance-00000001</name>
<uuid>54711b56-fa72-4eac-a5d3-aa29ed128098</uuid>
<metadata>
<nova:instance xmlns:nova="http://openstack.org/xmlns/libvirt/nova/1.0";>
<nova:package version="13.0.0"/>
<nova:name>asdf</nova:name>
<nova:creationTime>2016-03-03 16:02:39</nova:creationTime>
<nova:flavor name="m1.tiny">
<nova:memory>512</nova:memory>
<nova:disk>1</nova:disk>
<nova:swap>0</nova:swap>
<nova:ephemeral>0</nova:ephemeral>
<nova:vcpus>1</nova:vcpus>
</nova:flavor>
<nova:owner>
<nova:user uuid="96e62e9067124d79aefb0234143287eb">admin</nova:user>
<nova:project
uuid="376f545938224be4ae76f283144dc31d">alt_demo</nova:project>
</nova:owner>
<nova:root type="image" uuid="d30c2fce-f882-4720-8367-e416cc15a32e"/>
</nova:instance>
</metadata>
<memory unit='KiB'>524288</memory>
<currentMemory unit='KiB'>524288</currentMemory>
<vcpu placement='static'>1</vcpu>
<cputune>
<shares>1024</shares>
</cputune>
<sysinfo type='smbios'>
<system>
<entry name='manufacturer'>OpenStack Foundation</entry>
<entry name='product'>OpenStack Nova</entry>
<entry name='version'>13.0.0</entry>
<entry name='serial'>03000200-0400-0500-0006-000700080009</entry>
<entry name='uuid'>54711b56-fa72-4eac-a5d3-aa29ed128098</entry>
<entry name='family'>Virtual Machine</entry>
</system>
</sysinfo>
<os>
<type arch='x86_64' machine='pc-i440fx-utopic'>hvm</type>
<kernel>/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/kernel</kernel>
<initrd>/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/ramdisk</initrd>
<cmdline>root=/dev/vda console=tty0 console=ttyS0</cmdline>
<boot dev='hd'/>
<smbios mode='sysinfo'/>
</os>
<features>
<acpi/>
<apic/>
</features>
<cpu>
<topology sockets='1' cores='1' threads='1'/>
</cpu>
<clock offset='utc'>
<timer name='pit' tickpolicy='delay'/>
<timer name='rtc' tickpolicy='catchup'/>
<timer name='hpet' present='no'/>
</clock>
<on_poweroff>destroy</on_poweroff>
<on_reboot>restart</on_reboot>
<on_crash>destroy</on_crash>
<devices>
<emulator>/usr/bin/kvm-spice</emulator>
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none'/>
<source
file='/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/disk'/>
<target dev='vda' bus='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x04'
function='0x0'/>
</disk>
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none'/>
<source
file='/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/disk.swap'/>
<target dev='vdb' bus='virtio'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x05'
function='0x0'/>
</disk>
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw' cache='none'/>
<source
file='/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/disk.config'/>
<target dev='hdd' bus='ide'/>
<readonly/>
<address type='drive' controller='0' bus='1' target='0' unit='1'/>
</disk>
<controller type='usb' index='0'>
<address type='pci' domain='0x0000' bus='0x00' slot='0x01'
function='0x2'/>
</controller>
<controller type='pci' index='0' model='pci-root'/>
<controller type='ide' index='0'>
<address type='pci' domain='0x0000' bus='0x00' slot='0x01'
function='0x1'/>
</controller>
<interface type='bridge'>
<mac address='fa:16:3e:a9:b5:c5'/>
<source bridge='br100'/>
<model type='virtio'/>
<filterref filter='nova-instance-instance-00000001-fa163ea9b5c5'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x03'
function='0x0'/>
</interface>
<serial type='file'>
<source
path='/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/console.log'/>
<target port='0'/>
</serial>
<serial type='pty'>
<target port='1'/>
</serial>
<console type='file'>
<source
path='/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/console.log'/>
<target type='serial' port='0'/>
</console>
<input type='mouse' bus='ps2'/>
<input type='keyboard' bus='ps2'/>
<graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1'
keymap='en-us'>
<listen type='address' address='127.0.0.1'/>
</graphics>
<video>
<model type='cirrus' vram='16384' heads='1'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02'
function='0x0'/>
</video>
<memballoon model='virtio'>
<address type='pci' domain='0x0000' bus='0x00' slot='0x06'
function='0x0'/>
<stats period='10'/>
</memballoon>
</devices>
</domain>
2016-03-03 10:02:41.417 ERROR nova.compute.manager
[req-dadee404-81c4-46de-9fd5-58de747b3b78 admin alt_demo] [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] Setting instance vm_state to ERROR
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] Traceback (most recent call last):
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/compute/manager.py", line 3999, in finish_resize
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] disk_info, image_meta)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/compute/manager.py", line 3964, in _finish_resize
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] old_instance_type)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 204, in
__exit__
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] six.reraise(self.type_, self.value,
self.tb)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/compute/manager.py", line 3959, in _finish_resize
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] block_device_info, power_on)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/virt/libvirt/driver.py", line 7202, in finish_migration
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] vifs_already_plugged=True)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/virt/libvirt/driver.py", line 4862, in
_create_domain_and_network
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] xml, pause=pause, power_on=power_on)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/virt/libvirt/driver.py", line 4793, in _create_domain
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] guest.launch(pause=pause)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/virt/libvirt/guest.py", line 142, in launch
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] self._encoded_xml, errors='ignore')
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 204, in
__exit__
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] six.reraise(self.type_, self.value,
self.tb)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/opt/stack/nova/nova/virt/libvirt/guest.py", line 137, in launch
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] return
self._domain.createWithFlags(flags)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/usr/local/lib/python2.7/dist-packages/eventlet/tpool.py", line 183, in doit
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] result = proxy_call(self._autowrap,
f, *args, **kwargs)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/usr/local/lib/python2.7/dist-packages/eventlet/tpool.py", line 141, in
proxy_call
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] rv = execute(f, *args, **kwargs)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/usr/local/lib/python2.7/dist-packages/eventlet/tpool.py", line 122, in execute
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] six.reraise(c, e, tb)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/usr/local/lib/python2.7/dist-packages/eventlet/tpool.py", line 80, in tworker
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] rv = meth(*args, **kwargs)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] File
"/usr/local/lib/python2.7/dist-packages/libvirt.py", line 1037, in
createWithFlags
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] if ret == -1: raise libvirtError
('virDomainCreateWithFlags() failed', dom=self)
2016-03-03 10:02:41.417 TRACE nova.compute.manager [instance:
54711b56-fa72-4eac-a5d3-aa29ed128098] libvirtError: Cannot access storage file
'/opt/stack/data/nova/instances/54711b56-fa72-4eac-a5d3-aa29ed128098/disk.swap'
(as uid:109, gid:118): No such file or directory
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1552777/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
