Reviewed: https://review.opendev.org/699858 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9637d733749d741d5aac3b89b92e100d32fbdbb0 Submitter: Zuul Branch: master
commit 9637d733749d741d5aac3b89b92e100d32fbdbb0 Author: KeithMnemonic <[email protected]> Date: Wed Dec 18 11:22:09 2019 -0800 Fix "prev" link pagination for instances with identical timestamps This patch resolves an issue with the "prev" link when instances have identical "created_at" values. This can occur when creating instance using the "min/max count" option. The reverse sort does not work correctly as the server list returned from nova is not an exact reverse as the forward sort. It looks like the combination of sort_keys must be unique to ensure the forward and reverse pagination properly. As a workaround 'uuid' (server ID) is added to 'sort_keys'. In addition, 'display_name' is added before 'uuid' in 'sort_keys' to list servers in the alphabetical order (which sounds natural). Closes-Bug #1856243 Change-Id: I73234b2c69ce8ea648b4a9721abe4f5670031909 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1856243 Title: "prev" link in Horizon instances panel does not paginate correctly. Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The prev link that appears on an "Instances" page when the number of instances is greater than the admin setting of "Items per page" is not working. This is easily reproducible on devstack (master) by doing the following 1) I create 5 test instances test-1 to test-5 2) In Settings found by clicking the admin button on the upper right side in Horizon, I change "Items per page to 2" 3) In the Instances page, I see for example test-5 and test-4. 4) If I click "next" it now shows test-2 and test-1. 5) If I now click "prev", it shows test-3 and test-1 6) If I click next it now shows test-3. 7) If I click prev, I get nothing. It seems if you only click next, it does step forward correctly. something with "prev" seems to not keep the correct sort order. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1856243/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
