Reviewed: https://review.openstack.org/511209 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0184bb4798dd4660182062fe4099a07e63dd90e8 Submitter: Jenkins Branch: master
commit 0184bb4798dd4660182062fe4099a07e63dd90e8 Author: Ildiko Vancsa <[email protected]> Date: Wed Oct 11 12:56:02 2017 +0200 Fix connection info refresh for reboot The 'bdms' parameter is not referenced correctly in _get_instance_block_device_info in compute/manager.py which causes the function to call down to the bdm to refresh the connection_info which is not supposed to happen during reboot. The patch fixes to use the optional parameter correctly. Fixes-Bug: #1722771 Change-Id: I5545d0807626b353ca723ab1f125fd1f94bcef2e ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1722771 Title: Connection_info is refreshed on reboot unintentionally Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) ocata series: Confirmed Status in OpenStack Compute (nova) pike series: Confirmed Bug description: _get_instance_block_device_info is called without explicitly specifying 'bdms' which is an optional parameter here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3044 Function definition: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1659 This results in triggering connection_info refresh, which is unnecessary and also causes problems with implementing the new style attachment flow. Related logs: http://logs.openstack.org/31/511031/1/check/gate-nova- tox-functional-ubuntu- xenial/3744c55/console.html#_2017-10-11_00_35_23_981104 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1722771/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
