Reviewed: https://review.openstack.org/478720
Committed:
https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb4ae6bbda8f45429bf1c5f34a61292586847742
Submitter: Jenkins
Branch: master
commit fb4ae6bbda8f45429bf1c5f34a61292586847742
Author: Ying Zuo <yin...@cisco.com>
Date: Wed Jun 28 21:08:54 2017 -0700
Fix subnets can not be deleted from network topology panel
The structure of DetailView was changed, so the url for the delete
subnet action needs to be updated so that subnets can be deleted properly.
Added the required method get_subnets_data in DetailView.
Added JS code to remove the subnet from the network node on network
topology panel after the subnet is deleted.
Fixed router interface not being removed from the network topology
panel after it's deleted.
Closes-bug: #1643414
Change-Id: I60cc161655b994c8e3ace5efc37459f3e9e60d67
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1643414
Title:
Error on 'delete subnet' in network topology panel
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
Cant delete subnet on network topology
Steps to Reproduce:
================
1. Open Project/Network/network topology panel;
2. Click the network icon, and there will display a new modal of the net info
3. Click the 'Delete Subnet' on the new modal.
Actual results:
===========
Subnet does not delete, and there will cast error in the console:
File "/root/code_review/horizon/horizon/decorators.py", line 84, in dec
return view_func(request, *args, **kwargs)
File
"/root/code_review/horizon/.venv/lib/python2.7/site-packages/django/views/generic/base.py",
line 65, in view
self = cls(**initkwargs)
File "/root/code_review/horizon/horizon/tabs/views.py", line 87, in __init__
super(TabbedTableView, self).__init__(*args, **kwargs)
File "/root/code_review/horizon/horizon/tables/views.py", line 34, in
__init__
self.get_data_methods(self.table_classes, self._data_methods)
File "/root/code_review/horizon/horizon/tables/views.py", line 61, in
get_data_methods
name)
File "/root/code_review/horizon/horizon/tables/views.py", line 78, in
check_method_exist
"in %s." % (func_name, cls_name))
NotImplementedError: You must define a get_subnets_data method in
NetworkDetailView.
Expected results:
==============
Subnet should delete
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1643414/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
