Reviewed: https://review.openstack.org/296305
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=f15d9a9693b19393fcde84cf4bc6f044d39ffdca
Submitter: Jenkins
Branch: master
commit f15d9a9693b19393fcde84cf4bc6f044d39ffdca
Author: Moshe Levi <mosh...@mellanox.com>
Date: Wed Mar 23 10:59:04 2016 +0200
Fix detach SR-IOV when using LibvirtConfigGuestHostdevPCI
This patch fixes an issue which was introduced by this
change If3edc1965c01a077eb61984a442e0d778d870d75.
Usually the vif config is of type LibvirtConfigGuestInterface,
but some vif use LibvirtConfigGuestHostdevPCI config
(e.g. the ib_hostdev). The difference is that
LibvirtConfigGuestInterface keeps the pci address in source_dev
while LibvirtConfigGuestHostdevPCI has domain, bus, slot and
function, instead of relying on the vif config type we can take the
pci address for the neutron port.
Closes-Bug: #1560860
Change-Id: I62a7ff16f1c9c5da923451520fbeeabb5cc0c5c6
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1560860
Title:
mellanox infiniband SR-IOV(ib_hostdev vif) detach port fails
Status in OpenStack Compute (nova):
Fix Released
Status in OpenStack Compute (nova) mitaka series:
New
Bug description:
detaching SRIOV port direct causes exception.
# neutron port-create --binding:vnic_type=direct private
# nova boot --flavor m1.small --image cirros-mellanox-x86_64-disk-ib --nic
port-id=a247d89e-dae5-4d65-b414-e7bf3a26bfd1 vm1
# nova suspend vm1
logs:
https://review.openstack.org/#/c/286668
http://144.76.193.39/ci-artifacts/286668/3/Neutron-Networking-MLNX-ML2/
Traceback message
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] Traceback (most recent call last):
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] File
"/opt/stack/nova/nova/compute/manager.py", line 6515, in
_error_out_instance_on_exception
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] yield
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] File
"/opt/stack/nova/nova/compute/manager.py", line 4172, in suspend_instance
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] self.driver.suspend(context, instance)
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] File
"/opt/stack/nova/nova/virt/libvirt/driver.py", line 2638, in suspend
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] self._detach_sriov_ports(context,
instance, guest)
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] File
"/opt/stack/nova/nova/virt/libvirt/driver.py", line 3425, in _detach_sriov_ports
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] if vif['vnic_type'] in
network_model.VNIC_TYPES_SRIOV
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730] AttributeError:
'LibvirtConfigGuestHostdevPCI' object has no attribute 'source_dev'
2016-03-03 04:45:42.775 1801 ERROR nova.compute.manager [instance:
cdf2e34d-bc2e-4edb-aff7-516b97487730]
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1560860/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
