Public bug reported:
The horizon.scss now @imports _variables after importing bootstrap,
which prevents us to override bootstrap variables there. (see how scss
variables overriding work http://robots.thoughtbot.com/sass-default)
The fix should move _variables import before bootstrap import in
horizon.scss and move all variables defined at the beginning of
horizon.scss into _variables.scss.
Also, variables in _variables.scss shoudl be organized into 2 groups for
clarity:
1. bootstrap overrides - variables that override bootstrap ones
2. custom horizon variables - variables used by horizon that are not defined by
bootstrap
IMHO, all variables in _variables.scss should be marked as !default, so
they can be overriden in horizon plugins to maintain Horizon's
customization ability.
** Affects: horizon
Importance: Undecided
Assignee: Jiri Tomasek (jtomasek)
Status: In Progress
** Tags: scss
** Changed in: horizon
Assignee: (unassigned) => Jiri Tomasek (jtomasek)
** Changed in: horizon
Status: New => In Progress
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1390101
Title:
scss variables overriding mechanism
Status in OpenStack Dashboard (Horizon):
In Progress
Bug description:
The horizon.scss now @imports _variables after importing bootstrap,
which prevents us to override bootstrap variables there. (see how scss
variables overriding work http://robots.thoughtbot.com/sass-default)
The fix should move _variables import before bootstrap import in
horizon.scss and move all variables defined at the beginning of
horizon.scss into _variables.scss.
Also, variables in _variables.scss shoudl be organized into 2 groups for
clarity:
1. bootstrap overrides - variables that override bootstrap ones
2. custom horizon variables - variables used by horizon that are not defined
by bootstrap
IMHO, all variables in _variables.scss should be marked as !default,
so they can be overriden in horizon plugins to maintain Horizon's
customization ability.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1390101/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
