Reviewed: https://review.openstack.org/51511 Committed: http://github.com/openstack/keystone/commit/a0ae37eb3ea96a394f10d3f38e8b454d2d7a98e0 Submitter: Jenkins Branch: milestone-proposed
commit a0ae37eb3ea96a394f10d3f38e8b454d2d7a98e0 Author: Morgan Fainberg <m...@metacloud.com> Date: Sun Oct 13 18:34:24 2013 -0700 Handle unicode at the caching layer more elegantly This patchset resolves an issue where in some cases unicode would cause the cache key generator to raise a UnicodeEncodeError due to the name/value being outside of the standard ascii character set. Included is a fix to the cache backend debug code to utilize repr for passing the keys/values to the logger. Tests in test_backend provided by chenxiao <chenx...@cn.ibm.com> Closes-bug: 1237892 Change-Id: Ic99503987851128cd41d83ad1ea50dc4a132fbd3 ** Changed in: keystone Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Keystone. https://bugs.launchpad.net/bugs/1237892 Title: UnicodeEncodeError when Running CLI keystone tenant-delete action with non-English characters Status in OpenStack Identity (Keystone): Fix Released Bug description: keystone tenant-delete action with non-English characters occurs UnicodeEncodeError in log file, but the tenant has been delete in fact. input below command: [[root@osee22-compute02 ˜]# keystone tenant-delete testソ十豹 [root@osee22-compute02 ˜]# keystone tenant-list +----------------------------------+---------+---------+ | id | name | enabled | +----------------------------------+---------+---------+ | e7308b169a784693b39c60e152c7d01a | Public | True | | 9b78773f34264a428073412ef7d5485e | service | True | +----------------------------------+---------+---------+ log: 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi Traceback (most recent call last): 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi File "/usr/lib/python2.6/site-packages/keystone/common/wsgi.py", line 238, in __call__ 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi result = method(context, **params) 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi File "/usr/lib/python2.6/site-packages/keystone/identity/controllers.py", line 124, in delete_project 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi self.assignment_api.delete_project(tenant_id) 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi File "/usr/lib/python2.6/site-packages/keystone/notifications.py", line 44, in wrapper 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi result = f(*args, **kwargs) 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi File "/usr/lib/python2.6/site-packages/keystone/assignment/core.py", line 93, in delete_project 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi project['domain_id']) 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi File "/usr/lib/python2.6/site-packages/dogpile/cache/region.py", line 939, in invalidate 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi key = key_generator(*arg, **kw) 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi File "/usr/lib/python2.6/site-packages/dogpile/cache/util.py", line 86, in generate_key 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi return namespace + "|" + " ".join(map(to_str, args)) 2013-09-25 21:06:50.280 3622 TRACE keystone.common.wsgi UnicodeEncodeError: 'ascii' codec can't encode characters in position 4-6: ordinal not in range(128) To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1237892/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp