On 22/06/2021 16:20, Jan Beulich wrote: > libxc generally uses uint32_t to represent domain IDs. This is fine as > long as addresses of such variables aren't taken, to then pass into > hypercalls: To the hypervisor, a domain ID is a 16-bit value. Introduce > a wrapper struct to deal with the issue. (On architectures with > arguments passed in registers, an intermediate variable would have been > created by the compiler already anyway, just one of the wrong type.) > > The public interface change is both source and binary compatible for > the architectures we currently support. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > Acked-by: Ian Jackson <i...@xenproject.org>
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > v2: Introduce wrapper struct in public interface. > --- > Together with the comment change I was half tempted to also rename the > sub-function identifier to XENMEM_maximum_gfn. But I then decided this > would go too far here. We ought to fix it, but that could be a followup, or could be when this interface disappears in ABIv2. ~Andrew
