On 03.05.2021 21:28, Jason Andryuk wrote:
> --- a/tools/misc/xenpm.c
> +++ b/tools/misc/xenpm.c
> @@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[])
> /* print out parameters about cpu frequency */
> static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para
> *p_cpufreq)
> {
> + bool internal = strstr(p_cpufreq->scaling_governor, "internal");
Like suggested for the hypervisor, perhaps better check for names
ending in "-internal"?
> @@ -720,10 +721,19 @@ static void print_cpufreq_para(int cpuid, struct
> xc_get_cpufreq_para *p_cpufreq)
> printf(" %d", p_cpufreq->affected_cpus[i]);
> printf("\n");
>
> - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n",
> - p_cpufreq->cpuinfo_max_freq,
> - p_cpufreq->cpuinfo_min_freq,
> - p_cpufreq->cpuinfo_cur_freq);
> + if ( internal )
> + {
> + printf("cpuinfo frequency : base [%u] turbo [%u]\n",
> + p_cpufreq->cpuinfo_min_freq,
> + p_cpufreq->cpuinfo_max_freq);
> + }
> + else
> + {
> + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n",
> + p_cpufreq->cpuinfo_max_freq,
> + p_cpufreq->cpuinfo_min_freq,
> + p_cpufreq->cpuinfo_cur_freq);
> + }
Since the file adopts hypervisor coding style, the unnecessary
braces would again better be omitted.
Jan
