On 23/03/2021 09:58, Roger Pau Monne wrote: > Move the logic from xc_cpu_policy_apply_cpuid into libxl, now that the > xc_cpu_policy_* helpers allow modifying a cpu policy. Having xenguest > parsing CPUID data in xend format was a layering violation, and by > moving such parsing into libxl directly we can get rid of > xc_xend_cpuid, as libxl will now implement it's own private type for > storing CPUID information, which currently matches xc_xend_cpuid. > > Note the function logic is moved as-is, but requires adapting to the > libxl coding style. > > No functional change intended. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Its not a layering violation IMO. It was only in 4.14 that I dropped the Python and Ocaml bindings for xend-format strings, in an effort to simplify this work. Before then, libxc was absolutely the correct place for the logic to live. I do intend to re-add python bindings in due course, but I really don't expect that to extend to the xend format. So moving this logic probably fine, unless we're expecting to re-introduce it elsewhere? ~Andrew
