Andrew Cooper writes ("[PATCH 09/10] tools/libs: Add rule to generate 
headers.lst"):
> abi-dumper needs a list of the public header files for shared objects, and
> only accepts this in the form of a file.

Release-Acked-by: Ian Jackson <i...@xenproject.org>

because it's not run by default, but...

> +headers.lst: FORCE
> +     @{ $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp

Missing set -e.  If the disk fills up temporarily you might get a
partial file here...

> +     @$(call move-if-changed,$@.tmp,$@)

Ian.

Reply via email to