On 12/02/2021 16:04, Jan Beulich wrote: > On 12.02.2021 16:39, Andrew Cooper wrote: >> The recommended optimisation level for debugging is -Og, and is what tools >> such as gdb prefer. In practice, it equates to -01 with a few specific >> optimisations turned off. >> >> abi-dumper in particular wants the libraries it inspects in this form. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com>
Thanks, > >> --- a/tools/Rules.mk >> +++ b/tools/Rules.mk >> @@ -106,8 +106,9 @@ endif >> CFLAGS_libxenlight += $(CFLAGS_libxenctrl) >> >> ifeq ($(debug),y) >> -# Disable optimizations >> -CFLAGS += -O0 -fno-omit-frame-pointer >> +# Use -Og if available, -O0 otherwise >> +dbg_opt_level := $(call cc-option,$(CC),-Og,-O0) >> +CFLAGS += $(dbg_opt_level) -fno-omit-frame-pointer > I wonder if we shouldn't do something similar for the hypervisor, > where we use -O1 for debug builds right now. At least when > DEBUG_INFO is also enabled, -Og may be better. I also made that work... its rather more invasive in terms of changes - all for "maybe uninitialised" warnings. $ git diff e2bab84984^ --stat xen/Makefile | 3 ++- xen/arch/arm/domain_build.c | 2 +- xen/arch/x86/irq.c | 2 +- xen/arch/x86/mm/shadow/common.c | 2 +- xen/arch/x86/pv/shim.c | 6 +++--- xen/arch/x86/sysctl.c | 4 ++-- xen/common/efi/boot.c | 2 +- 7 files changed, 11 insertions(+), 10 deletions(-) is what is required to make Gitlab happy. I was planning to defer it to 4.16 at this point. ~Andrew
