Roger Pau Monne writes ("[PATCH for-4.15] x86/efi: enable MS ABI attribute on
clang"):
> Or else the EFI service calls will use the wrong calling convention.
>
> The __ms_abi__ attribute is available on all supported versions of
> clang.
>
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
> ---
> Cc: Ian Jackson <i...@xenproject.org>
>
> Without this a Xen built with clang won't be able to correctly use the
> EFI services, leading to weird messages from the firmware and crashes.
> The impact of this fix for GCC users is exactly 0, and will fix the
> build on clang.
Reviewed-by: Ian Jackson <i...@xenproject.org>
> The biggest fallout from this could be using the attribute on a
> compiler that doesn't support it, which would translate into a build
> failure, but the gitlab tests have shown no issues.
Release-Acked-by: Ian Jackson <i...@xenproject.org>
Thanks for the thorough attention to the release question in your
mails. You're making my work very easy :-).
Ian.
