On 03/02/2021 17:58, Roger Pau Monne wrote: > Or else the EFI service calls will use the wrong calling convention. > > The __ms_abi__ attribute is available on all supported versions of > clang. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > Cc: Ian Jackson <i...@xenproject.org> > > Without this a Xen built with clang won't be able to correctly use the > EFI services, leading to weird messages from the firmware and crashes. > The impact of this fix for GCC users is exactly 0, and will fix the > build on clang. DYM "fix the compiled binary"? The build on clang isn't broken atm, but it provably has the wrong ABI. ~Andrew
