> -----Original Message-----
> From: Andrew Cooper <am...@cam.ac.uk>
> Sent: 11 January 2021 21:23
> To: p...@xen.org; 'Xen-devel' <xen-devel@lists.xenproject.org>
> Cc: 'George Dunlap' <george.dun...@eu.citrix.com>; 'Ian Jackson'
> <i...@xenproject.org>; 'Jan Beulich'
> <jbeul...@suse.com>; 'Stefano Stabellini' <sstabell...@kernel.org>; 'Wei Liu'
> <w...@xen.org>; 'Julien
> Grall' <jul...@xen.org>; 'Michał Leszczyński' <michal.leszczyn...@cert.pl>;
> 'Hubert Jasudowicz'
> <hubert.jasudow...@cert.pl>; 'Tamas K Lengyel' <ta...@tklengyel.com>; Andrew
> Cooper <am...@cam.ac.uk>
> Subject: Re: [PATCH v2 02/11] xen/gnttab: Rework resource acquisition
>
> On 24/09/2020 10:51, Paul Durrant wrote:
> >> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> >> index a5d3ed8bda..912f07be47 100644
> >> --- a/xen/common/grant_table.c
> >> +++ b/xen/common/grant_table.c
> >> @@ -4013,6 +4013,81 @@ static int gnttab_get_shared_frame_mfn(struct
> >> domain *d,
> >> return 0;
> >> }
> >>
> >> +int gnttab_acquire_resource(
> >> + struct domain *d, unsigned int id, unsigned long frame,
> >> + unsigned int nr_frames, xen_pfn_t mfn_list[])
> >> +{
> >> + struct grant_table *gt = d->grant_table;
> >> + unsigned int i = nr_frames, tot_frames;
> >> + mfn_t tmp;
> >> + void **vaddrs = NULL;
> >> + int rc;
> >> +
> >> + /* Input sanity. */
> > Nit: inconsistency with full stops on single line comments.
>
> The whole point of relaxing the style was because feedback over minutia
> such as this was deemed detrimental to the community.
>
> If I ever see feedback like this, I will commit commit the patch there
> and then. This is the only way upstream Xen is going to turn into a
> less toxic environment for contributors.
The tone of your response rather proves that Xen is already a toxic
environment, I'm afraid.
Paul
