On 11.01.2021 22:22, Andrew Cooper wrote:
> On 24/09/2020 10:51, Paul Durrant wrote:
>>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
>>> index a5d3ed8bda..912f07be47 100644
>>> --- a/xen/common/grant_table.c
>>> +++ b/xen/common/grant_table.c
>>> @@ -4013,6 +4013,81 @@ static int gnttab_get_shared_frame_mfn(struct domain
>>> *d,
>>> return 0;
>>> }
>>>
>>> +int gnttab_acquire_resource(
>>> + struct domain *d, unsigned int id, unsigned long frame,
>>> + unsigned int nr_frames, xen_pfn_t mfn_list[])
>>> +{
>>> + struct grant_table *gt = d->grant_table;
>>> + unsigned int i = nr_frames, tot_frames;
>>> + mfn_t tmp;
>>> + void **vaddrs = NULL;
>>> + int rc;
>>> +
>>> + /* Input sanity. */
>> Nit: inconsistency with full stops on single line comments.
>
> The whole point of relaxing the style was because feedback over minutia
> such as this was deemed detrimental to the community.
>
> If I ever see feedback like this, I will commit commit the patch there
> and then. This is the only way upstream Xen is going to turn into a
> less toxic environment for contributors.
Paul had clearly marked this as "nit". ./CODING_STYLE explicitly
allows omission as well as presence of a full stop here. So while
I agree with you that you'd be okay ignoring such a remark, I
also agree with Paul giving the remark if he's found a nearby
comment using the opposite variant. Besides relaxing requirements
where sensible, at least local consistency also helps avoid such
comments (now or for future contributors).
Jan
