On Fri, Nov 06, 2020 at 10:37:35AM +0100, Jan Beulich wrote: > When shattering a large page, we first construct the new page table page > and only then hook it up. The "pre" hook in this case does nothing, for > the page starting out all blank. Avoid 512 calls into shadow code in > this case by passing in INVALID_GFN, indicating the page being updated > is (not yet) associated with any GFN. (The alternative to this change > would be to actually pass in a correct GFN, which can't be all the same > on every loop iteration.) > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Acked-by: Roger Pau Monné <roger....@citrix.com> I agree it's silly to pass the gfn when populating the page table page, as there's no gfn being updated (yet). Thanks, Roger.
