On 30.11.2020 11:31, Oleksandr Tyshchenko wrote: > --- a/xen/include/asm-x86/hvm/ioreq.h > +++ b/xen/include/asm-x86/hvm/ioreq.h > @@ -19,8 +19,7 @@ > #ifndef __ASM_X86_HVM_IOREQ_H__ > #define __ASM_X86_HVM_IOREQ_H__ > > -#define HANDLE_BUFIOREQ(s) \ > - ((s)->bufioreq_handling != HVM_IOREQSRV_BUFIOREQ_OFF) > +#include <xen/ioreq.h>
Is there a strict need to do it this way round? Usually the common header would include the arch one ... > @@ -38,42 +37,6 @@ int arch_ioreq_server_get_type_addr(const struct domain *d, > uint64_t *addr); > void arch_ioreq_domain_init(struct domain *d); As already mentioned in an earlier reply: What about these? They shouldn't get declared once per arch. If anything, ones that want to be inline functions can / should remain in the per-arch header. Jan
